feat: ICS20 Transfer v2 message #2102
Open
+40
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulikthebird
force-pushed
the
tkulik/feat/ics_20_tranfer_v2
branch
3 times, most recently
from
61661b9 to
dbc5a20
Compare
kulikthebird
force-pushed
the
tkulik/feat/ics_20_tranfer_v2
branch
from
dbc5a20 to
e1c44e8
Compare
kulikthebird
force-pushed
the
tkulik/feat/ics_20_tranfer_v2
branch
from
f05e87e to
d925bbc
Compare
chipshort
reviewed
Jan 31, 2025
Comment on lines
+230
to
+233
| github.com/CosmWasm/wasmvm/v2 v2.2.2-0.20250127092931-0322ca5cbd27 h1:E7YmMpKjj3wHvtxCesEoCNcg7ft502+U+QSUycqvkDM= | ||
| github.com/CosmWasm/wasmvm/v2 v2.2.2-0.20250127092931-0322ca5cbd27/go.mod h1:bMhLQL4Yp9CzJi9A83aR7VO9wockOsSlZbT4ztOl6bg= | ||
| github.com/CosmWasm/wasmvm/v2 v2.2.2-0.20250129191107-3c641d99ee15 h1:Bjd0MInujGk6AvWbjDnyCqCJh5UCAzRu7qqfuO+x7fI= | ||
| github.com/CosmWasm/wasmvm/v2 v2.2.2-0.20250129191107-3c641d99ee15/go.mod h1:bMhLQL4Yp9CzJi9A83aR7VO9wockOsSlZbT4ztOl6bg= |
There was a problem hiding this comment.
This needs a go mod tidy, but that can wait until the actual wasmvm release is ready.
Comment on lines
+325
to
+332
| tokens := []sdk.Coin{} | ||
| for _, token := range msg.TransferV2.Tokens { | ||
| coin, err := ConvertWasmCoinToSdkCoin(token) | ||
| if err != nil { | ||
| return nil, errorsmod.Wrap(err, "amount") | ||
| } | ||
| tokens = append(tokens, coin) | ||
| } |
There was a problem hiding this comment.
Would it make sense to use ConvertWasmCoinsToSdkCoins here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.